Illegal characters in recipient address cause message loss

[ahathaway]

I had a user today who inadvertently included square brackets in the recipient address. On sending, SWA returned an error dialog ("methodName = send"), and the message disappeared from the Outbox but did not appear in Sent Items.

The SWA log showed the following (some data hidden):

Code: Select all

2006-07-19 11:06:24 StandardContext[/webmail]ip: 192.168.10.143; username: xxx.xxx@xxx.com; message: <SOAP-ENV:Fault><faultcode>SOAP-ENV:SER
VER.AddressException</faultcode><faultstring>methodName = send

</faultstring><detail><e:AddressException xmlns:e="http://scalix.com/errors"><message>methodName = send

</message><debug>javax.mail.internet.AddressException: Illegal character in local name in string ``[xxx@xxx.com]''
        at javax.mail.internet.InternetAddress.checkAddress(InternetAddress.java:903)
        at javax.mail.internet.InternetAddress.parse(InternetAddress.java:793)
        at javax.mail.internet.InternetAddress.parseHeader(InternetAddress.java:554)
        at javax.mail.internet.MimeMessage.getAddressHeader(MimeMessage.java:658)
        at javax.mail.internet.MimeMessage.getRecipients(MimeMessage.java:483)
        at javax.mail.Message.getAllRecipients(Message.java:273)
        at javax.mail.internet.MimeMessage.getAllRecipients(MimeMessage.java:498)
        at com.oddpost.server.module.SoapMail.send(SoapMail.java:1065)
        at sun.reflect.GeneratedMethodAccessor60.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at com.oddpost.soap.SoapModule.invokeMethod(SoapModule.java:238)
        at com.oddpost.soap.SoapRequestImpl.execute(SoapRequestImpl.java:139)
        at com.oddpost.server.HttpRequestHandler.handleRequest(HttpRequestHandler.java:222)
        at com.oddpost.server.SoapServlet.doPost(SoapServlet.java:50)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:709)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:237)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
        at com.oddpost.server.filter.HttpConfFilter.doFilter(HttpConfFilter.java:182)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:186)
        ... skipping the last 25 lines as irrelevant...
</debug></e:AddressException></detail></SOAP-ENV:Fault>



By the way, you can test this quite easily by sending a message via SWA with the recipient surrounded by brackets: e.g. [foo@foo.com].

Seems like SWA should probably check for illegal characters before sending, and give users a chance to correct them.

--Aaron